New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: collectibles scrollbar spacing #5394
fix: collectibles scrollbar spacing #5394
Conversation
Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>
Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>
…dger/firefly into feat/basic-media-for-collectibles
…dger/firefly into fix/collectibles-scrollbar-spacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue with this is, that this space is now reserved for the scrollbar.
This means, that if we dont have scrollbar, the space at the right is empty
Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com>
…dger/firefly into fix/collectibles-scrollbar-spacing
I've adjusted the margin / padding numbers a bit and the content now looks aligned correctly to the rightmost edge of the parent container for both gallery and details views. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awesome work 🚀
…ectibles-scrollbar-spacing
Summary
This PR merges into
feat/basic-media-for-collectibles
. This fixes the scrollbar spacing so that the scrollbar has similar spacing from the content that it does in the activityList component.Changelog
Relevant Issues
...
Testing
Platforms
Instructions
...
Checklist