Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collectibles scrollbar spacing #5394

Merged
merged 52 commits into from Dec 14, 2022

Conversation

kraftjs
Copy link
Contributor

@kraftjs kraftjs commented Dec 12, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

This PR merges into feat/basic-media-for-collectibles. This fixes the scrollbar spacing so that the scrollbar has similar spacing from the content that it does in the activityList component.

Changelog

- Please write a list of changes

Relevant Issues

Please list any related issues using development keywords.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

nicole-obrien and others added 24 commits December 9, 2022 15:44
Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>
Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>
…dger/firefly into feat/basic-media-for-collectibles
@kraftjs kraftjs self-assigned this Dec 12, 2022
@kraftjs kraftjs marked this pull request as ready for review December 12, 2022 20:10
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with this is, that this space is now reserved for the scrollbar.
This means, that if we dont have scrollbar, the space at the right is empty

@kraftjs
Copy link
Contributor Author

kraftjs commented Dec 13, 2022

The issue with this is, that this space is now reserved for the scrollbar. This means, that if we dont have scrollbar, the space at the right is empty

I've adjusted the margin / padding numbers a bit and the content now looks aligned correctly to the rightmost edge of the parent container for both gallery and details views.

Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome work 🚀

Base automatically changed from feat/basic-media-for-collectibles to stardust-develop December 14, 2022 13:15
@MarkNerdi996 MarkNerdi996 merged commit e0f5b95 into stardust-develop Dec 14, 2022
@MarkNerdi996 MarkNerdi996 deleted the fix/collectibles-scrollbar-spacing branch December 14, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix collectibles tab scrollbar spacing
4 participants