Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove collectibles folder from core library #5403

Merged
merged 1 commit into from Dec 13, 2022

Conversation

kraftjs
Copy link
Contributor

@kraftjs kraftjs commented Dec 13, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

There are two NFT related folders in lib/core: collectibles and nft. collectibles is deprecated in favor of nft and an artifact of initial work on the NFT milestone.

Changelog

- Delete collectibles folder from lib/core

Relevant Issues

Please list any related issues using development keywords.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@kraftjs kraftjs self-assigned this Dec 13, 2022
@kraftjs kraftjs linked an issue Dec 13, 2022 that may be closed by this pull request
4 tasks
@kraftjs kraftjs marked this pull request as ready for review December 13, 2022 03:01
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MarkNerdi996 MarkNerdi996 merged commit b4b3852 into stardust-develop Dec 13, 2022
@MarkNerdi996 MarkNerdi996 deleted the refactor/remove-collectibles-lib branch December 13, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Refactor lib to remove core/collectibles
2 participants