Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement voting flow #5415

Merged
merged 11 commits into from Dec 14, 2022
Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Dec 13, 2022

Summary

Allows the user to vote for events that are in the counting or voting open status.

Changelog

- Added VoteForProposal popup
- Removed duplicate and unused handleClientError()
- Wired up proposals so that they can be voted for

Relevant Issues

closes: #4864

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi added context:governance stardust Related to the Stardust Protocol labels Dec 13, 2022
@Tuditi Tuditi self-assigned this Dec 13, 2022
@Tuditi Tuditi marked this pull request as ready for review December 13, 2022 16:15
@Tuditi Tuditi assigned jeeanribeiro and unassigned jeeanribeiro Dec 13, 2022
packages/shared/locales/en.json Outdated Show resolved Hide resolved
Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@jeeanribeiro jeeanribeiro linked an issue Dec 14, 2022 that may be closed by this pull request
3 tasks
@jeeanribeiro jeeanribeiro merged commit be8b172 into stardust-develop Dec 14, 2022
@jeeanribeiro jeeanribeiro deleted the feat/implement-voting-flow branch December 14, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:governance stardust Related to the Stardust Protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Implement flow to vote for a proposal
2 participants