Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: reset collectibles router if account changes #5418

Merged

Conversation

MarkNerdi996
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 commented Dec 14, 2022

Changelog

- reset collectibles router if account changes

Relevant Issues

Closes #5414

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

nicole-obrien and others added 30 commits December 9, 2022 15:44
Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>
Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>
…dger/firefly into feat/basic-media-for-collectibles
@MarkNerdi996 MarkNerdi996 added type:enhancement Enhancement to existing feature context:wallet stardust Related to the Stardust Protocol context:collectibles labels Dec 14, 2022
@MarkNerdi996 MarkNerdi996 self-assigned this Dec 14, 2022
@MarkNerdi996 MarkNerdi996 linked an issue Dec 14, 2022 that may be closed by this pull request
3 tasks
@MarkNerdi996 MarkNerdi996 force-pushed the enhancement/reset-router-on-account-change branch from 45c1b78 to 76d37fc Compare December 14, 2022 08:28
Base automatically changed from feat/basic-media-for-collectibles to stardust-develop December 14, 2022 13:15
@nicole-obrien nicole-obrien merged commit 96ff2fe into stardust-develop Dec 14, 2022
@nicole-obrien nicole-obrien deleted the enhancement/reset-router-on-account-change branch December 14, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:collectibles context:wallet stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Reset collectibles tab when switching wallet
3 participants