Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat-mobile: add change password to settings #5424

Merged
merged 11 commits into from Dec 15, 2022
Merged

feat-mobile: add change password to settings #5424

merged 11 commits into from Dec 15, 2022

Conversation

begonaalvarezd
Copy link
Member

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Relevant Issues

Please list any related issues using development keywords.

Close #5116

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd added platform:mobile stardust Related to the Stardust Protocol labels Dec 14, 2022
@begonaalvarezd begonaalvarezd self-assigned this Dec 14, 2022
@begonaalvarezd begonaalvarezd marked this pull request as ready for review December 14, 2022 18:15
paul-boegelsack
paul-boegelsack suggested changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@paul-boegelsack paul-boegelsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool! 💯 I just have two minor things

packages/mobile/views/dashboard/drawers/profile/views/settings/SettingsRouter.svelte Outdated Show resolved Hide resolved
packages/mobile/lib/routers/routers/settings-router.ts Show resolved Hide resolved
paul-boegelsack
paul-boegelsack approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@paul-boegelsack paul-boegelsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@paul-boegelsack paul-boegelsack merged commit f1fe1a9 into stardust-develop Dec 15, 2022
@paul-boegelsack paul-boegelsack deleted the feat-mobile/settings-password-bego branch December 15, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-boegelsack paul-boegelsack paul-boegelsack approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@begonaalvarezd begonaalvarezd

Labels
stardust Related to the Stardust Protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@begonaalvarezd @paul-boegelsack