Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds proposal status polling #5428

Merged
merged 8 commits into from Dec 16, 2022
Merged

feat: adds proposal status polling #5428

merged 8 commits into from Dec 16, 2022

Conversation

jeeanribeiro
Copy link
Contributor

@jeeanribeiro jeeanribeiro commented Dec 14, 2022 •
edited

Summary

Adds proposal status polling, refactors the proposal status enum and adds the proposal statuses as a persistent storage

Changelog

- Adds getParticipationEventStatus in AccountManager

Relevant Issues

closes #5260

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro self-assigned this Dec 14, 2022
@jeeanribeiro jeeanribeiro linked an issue Dec 15, 2022 that may be closed by this pull request
[Task]: Add proposal status polling #5260
Closed
3 tasks
@jeeanribeiro jeeanribeiro marked this pull request as ready for review December 15, 2022 15:09
maxwellmattryan
maxwellmattryan reviewed Dec 15, 2022
View reviewed changes
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall; just a few minor requested changes 👍

packages/desktop/views/dashboard/governance/views/DetailsView.svelte Outdated Show resolved Hide resolved
packages/shared/lib/core/governance/actions/index.ts Outdated
Comment on lines 1 to 2
export * from './proposal-status-polling'
export * from './setVotingPower'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be either camelCase or kebab-case, just not both

packages/shared/lib/core/governance/constants/proposal-status-poll-interval.constant.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/governance/constants/proposal-status-poll-interval.constant.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/governance/stores/proposals-state.store.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/profile-manager/api/deregisterParticipationEvent.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/profile-manager/api/getVotingProposalState.ts Outdated Show resolved Hide resolved
Tuditi
Tuditi approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works like a charm! 💪

@Tuditi Tuditi merged commit e232fa5 into stardust-develop Dec 16, 2022
@Tuditi Tuditi deleted the feat/proposal-status-polling branch December 16, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwellmattryan maxwellmattryan maxwellmattryan left review comments

@Tuditi Tuditi Tuditi approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@jeeanribeiro jeeanribeiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add proposal status polling
3 participants
@jeeanribeiro @maxwellmattryan @Tuditi