Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flow to stop voting for a proposal #5432

Merged

Conversation

maxwellmattryan
Copy link
Contributor

@maxwellmattryan maxwellmattryan commented Dec 15, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

The user must be able to stop voting for a proposal (if it's currently being voted on).

Changelog

- Add popup flow to stop voting for proposal
- Add isVotingForProposal and stopVotingForProposal functions
- Alphabetized popup index component properties

Relevant Issues

Please list any related issues using development keywords.

Closes #5267

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Vote and stop voting for proposals.

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@maxwellmattryan maxwellmattryan added type:feature Adding a new feature or functionality context:governance stardust Related to the Stardust Protocol labels Dec 15, 2022
@maxwellmattryan maxwellmattryan linked an issue Dec 15, 2022 that may be closed by this pull request
4 tasks
@maxwellmattryan maxwellmattryan marked this pull request as ready for review December 15, 2022 22:24
@maxwellmattryan maxwellmattryan requested review from Tuditi and removed request for cvarley100 December 15, 2022 22:25
Tuditi
Tuditi previously requested changes Dec 16, 2022
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to change. At the moment an error always shows up when I click on a proposal that hasn't been voted for

Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@maxwellmattryan maxwellmattryan dismissed Tuditi’s stale review December 16, 2022 17:56

Jean and I worked on this together AND implemented your suggestions :)

@maxwellmattryan maxwellmattryan merged commit 518c0f2 into stardust-develop Dec 16, 2022
@maxwellmattryan maxwellmattryan deleted the feat/flow-to-stop-voting-for-a-proposal branch December 16, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:governance stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Implement flow to stop voting for a proposal
3 participants