Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-mobile: add lang and theme settings #5434

Merged

Conversation

paul-boegelsack
Copy link
Contributor

Summary

Adds language and theme settings for stardust mobile.

Changelog

- Adds views for langauge and theme settings

Relevant Issues

Closes #5109
Closes #5110

Testing

Enable language and theme feature flags

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@paul-boegelsack paul-boegelsack added type:feature Adding a new feature or functionality platform:mobile stardust Related to the Stardust Protocol labels Dec 16, 2022
@paul-boegelsack paul-boegelsack self-assigned this Dec 16, 2022
This was linked to issues Dec 16, 2022
@begonaalvarezd begonaalvarezd marked this pull request as ready for review December 16, 2022 13:39
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼 lgtm

@begonaalvarezd begonaalvarezd merged commit 84aec3d into stardust-develop Dec 16, 2022
@begonaalvarezd begonaalvarezd deleted the feat-mobile/add-lang-and-theme-settings branch December 16, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Settings: Language [Task]: Settings: Theme
2 participants