Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add error toast if media doesnt load #5436

Merged

Conversation

MarkNerdi996
Copy link
Contributor

Summary

This PR includes UI components to give the user information on why the NFT media doesnt get displayed

Changelog

- add warning toast to CollectiblesDetails if the filesize is larger than 20MB
- add error toast to CollectiblesDetails
- add warning tooltip icon to NFTGalleryItem if the filesize is larger than 20MB
- add error tooltip icon to NFTGalleryItem

Relevant Issues

Closes #5430

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:enhancement Enhancement to existing feature stardust Related to the Stardust Protocol context:nft labels Dec 16, 2022
@MarkNerdi996 MarkNerdi996 self-assigned this Dec 16, 2022
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX team have updated the designs with latest strings and states to use for each error type. Lets update this PR with those.

@kraftjs kraftjs merged commit 381be56 into stardust-develop Dec 20, 2022
@kraftjs kraftjs deleted the enhancement/add-error-toast-if-media-doesnt-load branch December 20, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:collectibles stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants