Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proposal status reactive display on register #5437

Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Dec 16, 2022

Summary

Create a registered event id store to track whether events have been added or not. We need this for reactively adding/removing events

...

Changelog

- Add registeredEventIds store

Relevant Issues

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi self-assigned this Dec 16, 2022
@Tuditi Tuditi force-pushed the fix/proposal-status-reactive-display-on-register branch from fa573aa to 22e5096 Compare December 16, 2022 13:38
Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change

Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a small fix, now LGTM!

@jeeanribeiro jeeanribeiro merged commit d520cb3 into stardust-develop Dec 17, 2022
@jeeanribeiro jeeanribeiro deleted the fix/proposal-status-reactive-display-on-register branch December 17, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants