fix: correct proposal state store #5474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
maxwellmattryan
suggested changes
Dec 21, 2022
packages/desktop/views/dashboard/governance/views/DetailsView.svelte
Outdated
Show resolved
Hide resolved
packages/shared/lib/contexts/governance/interfaces/proposal-state.interface.ts
Show resolved
Hide resolved
Comment on lines
1
to
+5
| import { get } from 'svelte/store' | ||
| import type { EventStatus } from '@iota/wallet' | ||
| import { getVotingProposalState } from '@core/profile-manager/api' | ||
| import { activeProfileId } from '@core/profile/stores' | ||
| import { persistent } from '@core/utils/store' | ||
| import { IProposalState } from '../interfaces' |
There was a problem hiding this comment.
Would you mind cleaning the imports here too 🙏
| _proposalsState[eventId] = proposalStatus | ||
| proposalsState.set(_proposalsState) | ||
|
|
||
| const proposalStatus = await getVotingProposalState(eventId) |
There was a problem hiding this comment.
Maybe this should be proposalState rather than having "status" in the name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update proposals state so that it is per profile
Changelog
Relevant Issues
closes: #5452
Testing
Add the following line of code to reset proposalsState: https://github.com/iotaledger/firefly/blob/fix/correct-proposal-state-store/packages/shared/lib/contexts/governance/stores/proposals-state.store.ts#L10
proposalsState.set({})Platforms
Instructions
...
Checklist