Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat-mobile: delete profile #5476

Merged
merged 3 commits into from Dec 27, 2022
Merged

feat-mobile: delete profile #5476

merged 3 commits into from Dec 27, 2022

Conversation

begonaalvarezd
Copy link
Member

@begonaalvarezd begonaalvarezd commented Dec 21, 2022 •
edited

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

feat-mobile: delete profile

Relevant Issues

Please list any related issues using development keywords.

Close #5118

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd added type:feature Adding a new feature or functionality platform:mobile context:settings stardust Related to the Stardust Protocol labels Dec 21, 2022
@begonaalvarezd begonaalvarezd self-assigned this Dec 21, 2022
@begonaalvarezd begonaalvarezd linked an issue Dec 21, 2022 that may be closed by this pull request
[Task]: Settings: Delete profile #5118
Closed
MarkNerdi996
MarkNerdi996 approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkNerdi996 MarkNerdi996 merged commit fb2a772 into stardust-develop Dec 27, 2022
@MarkNerdi996 MarkNerdi996 deleted the feat-mobile/delete-profile branch December 27, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkNerdi996 MarkNerdi996 MarkNerdi996 approved these changes

@amadeu2 amadeu2 Awaiting requested review from amadeu2

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@begonaalvarezd begonaalvarezd

Labels
context:settings stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Settings: Delete profile
2 participants
@begonaalvarezd @MarkNerdi996