New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat-mobile: add change profile setting #5481
feat-mobile: add change profile setting #5481
Conversation
…ile/change-profile-name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the current profile doesnt get updated correctly after renaming it
- i think after updating, the app should go back to the settings or to the wallet
I dont agree with this point, I think the problem is that atm in mobile we are missing app notifications so you dont get a feedback about the profile name change, when we have the notifications I think the UX will improve already. We have an open issue to add and adjust mobile in-app notifications |
@MarkNerdi what do you mean? For me is working, is just that the notification is missing, but the profile changes name, if you logout (in this branch the logout is a bit buggy so you need to refresh, there is an open PR to fix logout) and login again, you can see your profile with a new name |
…le/change-profile-name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ile/change-profile-name
Summary
...
Changelog
Relevant Issues
Close #5113
Testing
Platforms
Instructions
...
Checklist