Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-mobile: add change profile setting #5481

Merged
merged 4 commits into from Dec 27, 2022

Conversation

begonaalvarezd
Copy link
Member

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

feat-mobile: add change profile setting

Relevant Issues

Please list any related issues using development keywords.

Close #5113

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd added type:feature Adding a new feature or functionality platform:mobile context:settings stardust Related to the Stardust Protocol labels Dec 21, 2022
@begonaalvarezd begonaalvarezd self-assigned this Dec 21, 2022
@begonaalvarezd begonaalvarezd linked an issue Dec 21, 2022 that may be closed by this pull request
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the current profile doesnt get updated correctly after renaming it
  • i think after updating, the app should go back to the settings or to the wallet

@begonaalvarezd
Copy link
Member Author

  • i think after updating, the app should go back to the settings or to the wallet

I dont agree with this point, I think the problem is that atm in mobile we are missing app notifications so you dont get a feedback about the profile name change, when we have the notifications I think the UX will improve already. We have an open issue to add and adjust mobile in-app notifications

@begonaalvarezd
Copy link
Member Author

  • the current profile doesnt get updated correctly after renaming it

@MarkNerdi what do you mean? For me is working, is just that the notification is missing, but the profile changes name, if you logout (in this branch the logout is a bit buggy so you need to refresh, there is an open PR to fix logout) and login again, you can see your profile with a new name

Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkNerdi996 MarkNerdi996 merged commit b79210e into stardust-develop Dec 27, 2022
@MarkNerdi996 MarkNerdi996 deleted the feat-mobile/change-profile-name branch December 27, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:settings stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Settings: Change profile name
2 participants