Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix incoming nfts on new account #5491

Merged
merged 4 commits into from Dec 22, 2022

Conversation

MarkNerdi996
Copy link
Contributor

Summary

If a new account is created, the nft store doesnt include a list for this account. Therefore we need to check if no list exists, and potentially create an empty one before adding elements to it

Changelog

- add empty list to NFT store if account gets created

Relevant Issues

Closes #5490

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:fix Fix for bug stardust Related to the Stardust Protocol context:nft labels Dec 22, 2022
@MarkNerdi996 MarkNerdi996 self-assigned this Dec 22, 2022
@MarkNerdi996 MarkNerdi996 changed the base branch from develop to stardust-develop December 22, 2022 10:55
Copy link
Contributor

@kraftjs kraftjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with minting and receiving NFTs. LGTM!

@kraftjs kraftjs merged commit f4cbb2d into stardust-develop Dec 22, 2022
@kraftjs kraftjs deleted the fix/fix-incoming-nfts-on-new-account branch December 22, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:collectibles stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: On newly created account, incoming NFTs throw errors
3 participants