Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: add isTransferring behavior to vote and stop vote #5493

Merged
merged 2 commits into from Dec 22, 2022
Merged

enhancement: add isTransferring behavior to vote and stop vote #5493

merged 2 commits into from Dec 22, 2022

Conversation

jeeanribeiro
Copy link
Contributor

Relevant Issues

closes #5468

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:enhancement Enhancement to existing feature context:governance type:ui stardust Related to the Stardust Protocol labels Dec 22, 2022
@jeeanribeiro jeeanribeiro self-assigned this Dec 22, 2022
@jeeanribeiro jeeanribeiro linked an issue Dec 22, 2022 that may be closed by this pull request
[Task]: De-bounce buttons around Governance operations #5468
Closed
5 tasks
Tuditi
Tuditi suggested changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, one minor code edit and then it's ready

packages/shared/components/popups/VoteForProposalPopup.svelte Show resolved Hide resolved
Tuditi
Tuditi approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Tuditi Tuditi merged commit 7cf484a into stardust-develop Dec 22, 2022
@Tuditi Tuditi deleted the enhancement/debounce-buttons-governance branch December 22, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@jeeanribeiro jeeanribeiro

Labels
context:governance stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature type:ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: De-bounce buttons around Governance operations
2 participants
@jeeanribeiro @Tuditi