Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-mobile: profile lock #5494

Merged
merged 6 commits into from Dec 29, 2022
Merged

Conversation

begonaalvarezd
Copy link
Member

@begonaalvarezd begonaalvarezd commented Dec 22, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

feat-mobile: profile lock
⚠️ Depends on #5492 & #5489, nested PR

image
image

Changelog

feat-mobile: profile lock

Relevant Issues

Please list any related issues using development keywords.

Close #5038

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd added type:feature Adding a new feature or functionality platform:mobile stardust Related to the Stardust Protocol labels Dec 22, 2022
@begonaalvarezd begonaalvarezd self-assigned this Dec 22, 2022
@begonaalvarezd begonaalvarezd linked an issue Dec 22, 2022 that may be closed by this pull request
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkNerdi996 MarkNerdi996 merged commit aa11033 into stardust-develop Dec 29, 2022
@MarkNerdi996 MarkNerdi996 deleted the feat-mobile/profile-lock branch December 29, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:settings stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Profile view: Profile Lock
2 participants