Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: register proposal via deep links #5500

Merged
merged 5 commits into from Dec 23, 2022

Conversation

maxwellmattryan
Copy link
Contributor

@maxwellmattryan maxwellmattryan commented Dec 23, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

Users will need to be able to register proposals via deep links on various websites.

Changelog

- Add Governance deep link context with initial "register proposal" operation 
- Update handbook documentation accordingly

Relevant Issues

Please list any related issues using development keywords.

Closees #4865

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Tested various valid and invalid deep links.

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@maxwellmattryan maxwellmattryan added type:feature Adding a new feature or functionality context:governance labels Dec 23, 2022
@maxwellmattryan maxwellmattryan self-assigned this Dec 23, 2022
@maxwellmattryan maxwellmattryan linked an issue Dec 23, 2022 that may be closed by this pull request
7 tasks
@maxwellmattryan maxwellmattryan marked this pull request as ready for review December 23, 2022 01:15
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Tuditi Tuditi merged commit 85d8ffe into stardust-develop Dec 23, 2022
@Tuditi Tuditi deleted the feat/register-proposal-via-deep-links branch December 23, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:governance type:feature Adding a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Register proposal via deep links
2 participants