Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get participation event not called after logout #5501

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Dec 23, 2022

Summary

This PR fixes some issues with polling and updating the proposals state after the account logged out already.

Changelog

- Only update proposalsState if activeProfileId is set
- Moved polling to login for consistency
- Add optional chaining

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi self-assigned this Dec 23, 2022
@Tuditi Tuditi added the type:fix Fix for bug label Dec 23, 2022
@Tuditi Tuditi marked this pull request as draft December 23, 2022 14:42
@Tuditi Tuditi marked this pull request as ready for review December 23, 2022 15:45
@Tuditi Tuditi force-pushed the fix/get-participation-event-not-called-after-logout branch from 2b28afa to 16dde31 Compare December 23, 2022 15:46
@jeeanribeiro jeeanribeiro merged commit 14aae56 into stardust-develop Dec 26, 2022
@jeeanribeiro jeeanribeiro deleted the fix/get-participation-event-not-called-after-logout branch December 26, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants