Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-mobile: max balance set undefined unit, and unit change validation #5521

Merged
merged 3 commits into from Dec 31, 2022
Merged

fix-mobile: max balance set undefined unit, and unit change validation #5521

merged 3 commits into from Dec 31, 2022

Conversation

begonaalvarezd
Copy link
Member

Summary

Please summarize your changes, describing what they are and why they were made.

There were 2 isues:

  • Unit change did not update rawAmount
  • Max balance click set unit to undefined

Additionally this PR adds focus to recipient input, which was missing

There is still a known bug around max balance click that also affects desktop and is not fixed in this PR
image

Changelog

- fix-mobile: max balance set undefined unit
- fix-mobile: unit change validation, update rawAmount

Relevant Issues

Please list any related issues using development keywords.

Close #5343
Close #5509

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd added type:fix Fix for bug platform:mobile stardust Related to the Stardust Protocol labels Dec 27, 2022
@begonaalvarezd begonaalvarezd self-assigned this Dec 27, 2022
@begonaalvarezd begonaalvarezd linked an issue Dec 27, 2022 that may be closed by this pull request
[Task]: Send Flow: Fix unit change not updating amount input #5343
Closed
@begonaalvarezd begonaalvarezd removed a link to an issue Dec 27, 2022
[Task]: Send Flow: Fix unit change not updating amount input #5343
Closed
This was linked to issues Dec 27, 2022
[Task]: Send Flow: Fix unit change not updating amount input #5343
Closed
[Task]: Send Flow: Fix max amount button #5509
Closed
@jeeanribeiro jeeanribeiro merged commit 1eba82b into stardust-develop Dec 31, 2022
@jeeanribeiro jeeanribeiro deleted the fix/max-and-unit branch December 31, 2022 14:15
jeeanribeiro added a commit that referenced this pull request Dec 31, 2022
@begonaalvarezd @jeeanribeiro
fix-mobile: max balance set undefined unit, and unit change validation (
966602e 
#5521)

* fix: send amount max balance & unit validation

* feat: recipient focus

Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeeanribeiro jeeanribeiro jeeanribeiro approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

@amadeu2 amadeu2 Awaiting requested review from amadeu2

Assignees

@begonaalvarezd begonaalvarezd

Labels
stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Send Flow: Fix max amount button [Task]: Send Flow: Fix unit change not updating amount input
2 participants
@begonaalvarezd @jeeanribeiro