Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-mobile: add fiat value to send amount #5523

Merged
merged 2 commits into from Dec 31, 2022

Conversation

begonaalvarezd
Copy link
Member

Summary

Please summarize your changes, describing what they are and why they were made.

Add fiat value to send amount

Please note that the design of the input itself needs to be improved because based on the size of the input value, the text is not centered, need to discuss with UX/UI

Changelog

feat-mobile: add fiat value to send amount

Relevant Issues

Please list any related issues using development keywords.

Close #5103

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd added platform:mobile stardust Related to the Stardust Protocol labels Dec 27, 2022
@begonaalvarezd begonaalvarezd self-assigned this Dec 27, 2022
@begonaalvarezd begonaalvarezd linked an issue Dec 27, 2022 that may be closed by this pull request
@jeeanribeiro jeeanribeiro merged commit 037e6d3 into stardust-develop Dec 31, 2022
@jeeanribeiro jeeanribeiro deleted the feat-mobile/send-amount-fiat branch December 31, 2022 14:36
jeeanribeiro added a commit that referenced this pull request Dec 31, 2022
Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Send Flow: Amout fiat value
2 participants