Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: de-bounce buttons on Governance actions #5531

Conversation

maxwellmattryan
Copy link
Contributor

@maxwellmattryan maxwellmattryan commented Dec 29, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

The register proposal popup needed to be slightly more robust.

Changelog

- Add de-bouncing / spinner to action button in register proposal popup
- Improve error handling around registering a proposal
- Cleanup some import statements, mainly alphabetizing them

Relevant Issues

Please list any related issues using development keywords.

Closes #5480

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Test registering a proposal, trying invalid event IDs, valid (but non-existent) event IDs, invalid node URLs, etc.

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@maxwellmattryan maxwellmattryan changed the base branch from develop to stardust-develop December 29, 2022 21:21
@maxwellmattryan maxwellmattryan self-assigned this Dec 29, 2022
@maxwellmattryan maxwellmattryan marked this pull request as ready for review December 29, 2022 21:58
Signed-off-by: Jean Ribeiro <contact@jeanribeiro.dev>
@jeeanribeiro jeeanribeiro force-pushed the fix/de-bounce-disable-buttons-whenever-managing-voting-power-tx-is-being-confirmed branch 2 times, most recently from c883208 to af3f9eb Compare December 31, 2022 01:23
…enever-managing-voting-power-tx-is-being-confirmed
@jeeanribeiro jeeanribeiro merged commit 3a765af into stardust-develop Dec 31, 2022
@jeeanribeiro jeeanribeiro deleted the fix/de-bounce-disable-buttons-whenever-managing-voting-power-tx-is-being-confirmed branch December 31, 2022 01:25
jeeanribeiro added a commit that referenced this pull request Dec 31, 2022
* chore: de-bounce action button for proposal registration popup

* chore: use consistent wording with other spots in app

* fix: handle errors for proposal and node

* fix isBusy

Signed-off-by: Jean Ribeiro <contact@jeanribeiro.dev>

Signed-off-by: Jean Ribeiro <contact@jeanribeiro.dev>
Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>
Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: De-bounce / disable buttons whenever managing voting power tx is being confirmed
2 participants