New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat-mobile: add shimmer claiming #5590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im getting an error when I try to claim my rewards
Error: Unable to initialize Shimmer claiming account
at initialiseFirstShimmerClaimingAccount
line throw new CannotInitialiseShimmerClaimingAccountError()
@Tuditi "Stronghold reported a procedure error: engine: fatal engine error: vault |
Should work now thanks to @Tuditi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have one tiny requested change - looks great!
packages/mobile/views/onboarding/views/profile-setup/views/index.js
Outdated
Show resolved
Hide resolved
I'm getting this error when trying to claim in a scenario where I've got funds on account index 2, address index 5:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great 💪🏼
Just 2 comments:
use the same seed in desktop & mobile, a seed that has unclaimed funds
get into the screen where your next step is just claiming, on both desktop and mobile
claim with desktop, so mobile cant claim anymore, though it knowns about the transaction
if will display an error because it cant claim twice the same funds
---- until here, all is good behavior
firefly mobile suggests "rerun", you press the button, nothing happens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Summary
Setup shimmer claiming for mobile onboarding
Changelog
Testing
Platforms
Instructions
...
Checklist