Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show selected vote on collapse instead of voted for #5611

Merged
merged 2 commits into from Jan 18, 2023
Merged

fix: show selected vote on collapse instead of voted for #5611

merged 2 commits into from Jan 18, 2023

Conversation

jeeanribeiro
Copy link
Contributor

Summary

When the question is collapsed, we always show the votedFor option. If a user clicks on another one, we should show that one to make it easier for the user to see what he will submit if he wants to change his vote.

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:fix Fix for bug context:governance stardust Related to the Stardust Protocol labels Jan 18, 2023
@jeeanribeiro jeeanribeiro self-assigned this Jan 18, 2023
@jeeanribeiro jeeanribeiro linked an issue Jan 18, 2023 that may be closed by this pull request
[Task]: Show selected vote instead of voted on vote when collapsing a question #5586
Closed
3 tasks
maxwellmattryan
maxwellmattryan approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@maxwellmattryan maxwellmattryan merged commit 8f100cd into develop Jan 18, 2023
@maxwellmattryan maxwellmattryan deleted the fix/show-selected-vote-on-collapse-instead-of-voted-for branch January 18, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwellmattryan maxwellmattryan maxwellmattryan approved these changes

@Tuditi Tuditi Awaiting requested review from Tuditi

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@jeeanribeiro jeeanribeiro

Labels
context:governance stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Show selected vote instead of voted on vote when collapsing a question
2 participants
@jeeanribeiro @maxwellmattryan