Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove text hint in VoteForProposalPopup #5612

Merged
merged 3 commits into from
Jan 19, 2023
Merged

fix: remove text hint in VoteForProposalPopup #5612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9210fd7
fix: remove text hint in VoteForProposalPopup
jeeanribeiro Jan 18, 2023
cdcfefd
Merge branch 'develop' into fix/remove-hint-vote-for-proposal-popup
jeeanribeiro Jan 19, 2023
cfe9f52
fix: fix text color on vote for proposal popup
MarkNerdi996 Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 2 additions & 7 deletions packages/shared/components/popups/VoteForProposalPopup.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script lang="typescript">
import { Button, Text, TextHint, FontWeight, TextType, KeyValueBox } from 'shared/components'
import { Button, Text, FontWeight, TextType, KeyValueBox } from 'shared/components'
import { HTMLButtonType } from 'shared/components/enums'
import { selectedAccount, updateSelectedAccount, vote } from '@core/account'
import { localize } from '@core/i18n'
Expand Down Expand Up @@ -60,7 +60,7 @@
<Text type={TextType.h4} fontWeight={FontWeight.semibold} classes="text-left">
{localize('popups.voteForProposal.title')}
</Text>
<Text type={TextType.p} secondary>
<Text fontSize="14" classes="text-left break-words">
{localize('popups.voteForProposal.body', {
values: {
proposal: $selectedProposal?.title,
Expand All @@ -69,11 +69,6 @@
</Text>
<div class="space-y-4">
<KeyValueBox keyText={localize('popups.voteForProposal.key')} valueText={formattedVotingPower} />
{#if hasVotingPower}
<TextHint info text={localize('popups.voteForProposal.hint')} />
{:else}
<TextHint danger text={localize('popups.voteForProposal.noVotingPower')} />
{/if}
</div>
<popup-buttons class="flex flex-row flex-nowrap w-full space-x-4">
<Button classes="w-full" outline onClick={closePopup}>{localize('actions.cancel')}</Button>
Expand Down
4 changes: 1 addition & 3 deletions packages/shared/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,9 +1017,7 @@
"voteForProposal": {
"title": "Vote for proposal",
"body": "You're about to vote for {proposal} proposal",
"key": "Your voting power",
"hint": "Please note that your voting power depends on the amount of funds you hold in your wallet. The more funds you hold, the higher your voting power is!",
"noVotingPower": "You do not have any voting power. Please increase your voting power from the Governance dashboard."
"key": "Your voting power"
},
"removeProposal": {
"title": "Remove proposal",
Expand Down