Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change vote activity #5614

Merged
merged 9 commits into from Jan 20, 2023
Merged

feat: change vote activity #5614

merged 9 commits into from Jan 20, 2023

Conversation

MarkNerdi996
Copy link
Contributor

Summary

This PR includes the activities for changing an already existing vote

Changelog

- activities for changing an already existing vote

Issue

Closes #5269

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 self-assigned this Jan 19, 2023
@MarkNerdi996 MarkNerdi996 added type:enhancement Enhancement to existing feature context:governance stardust Related to the Stardust Protocol labels Jan 19, 2023
Tuditi

This comment was marked as duplicate.

Sign in to view

Tuditi
Tuditi suggested changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons look oversized if you compare them with the designs. Could you make them a bit smaller? 🙏

packages/shared/locales/en.json Outdated
@@ -1243,6 +1243,8 @@
"decreasing": "Decreasing voting power",
"startVoting": "Voted",
"startingVoting": "Starting to vote",
"changedVote": "Vote changed",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change wording to:

Changed vote
Stopped vote

packages/shared/locales/en.json Outdated
},
"changedVote": {
"Pending": "changing vote for",
"Confirmed": "vote changed for",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Confirmed": "vote changed for",
"Confirmed": "changed vote for",

Tuditi
Tuditi suggested changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, the icon is not centered:

image

Tuditi
Tuditi approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🔥

@Tuditi Tuditi merged commit e4c372c into develop Jan 20, 2023
@Tuditi Tuditi deleted the feat/change-vote-activity branch January 20, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@MarkNerdi996 MarkNerdi996

Labels
context:governance stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Implement changed vote activity
2 participants
@MarkNerdi996 @Tuditi