Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix glow on voting power input #5617

Merged
merged 2 commits into from Jan 20, 2023
Merged

Conversation

MarkNerdi996
Copy link
Contributor

Summary

Fixes the issue that if glow are selected for voting power, decimals are displayed

Changelog

- fix max amount of decimals on amount input
- fix reset of errors on amount input
- fix button type on dropdown such that it doesnt submit anymore

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:fix Fix for bug context:wallet stardust Related to the Stardust Protocol labels Jan 19, 2023
@MarkNerdi996 MarkNerdi996 self-assigned this Jan 19, 2023
@MarkNerdi996 MarkNerdi996 linked an issue Jan 19, 2023 that may be closed by this pull request
3 tasks
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing to remove, otherwise it works fine!

Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tuditi Tuditi merged commit acf5f7a into develop Jan 20, 2023
@Tuditi Tuditi deleted the fix/fix-glow-for-voting-power branch January 20, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix selecting glow when managing voting power
2 participants