Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add hint if no voting power #5622

Merged
merged 1 commit into from Jan 20, 2023

Conversation

maxwellmattryan
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

If the user has no voting power, they are not warned or hinted that they need to increase it.

Changelog

- Add text hint back
- Remove unneeded locale

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Try voting with no voting power and some voting power.

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@maxwellmattryan maxwellmattryan self-assigned this Jan 19, 2023
@maxwellmattryan maxwellmattryan linked an issue Jan 19, 2023 that may be closed by this pull request
4 tasks
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Tuditi Tuditi merged commit bb9d92c into develop Jan 20, 2023
@Tuditi Tuditi deleted the fix/disallow-voting-if-no-voting-power branch January 20, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add hint if no voting power
2 participants