Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: state reset after logout #5624

Merged
merged 6 commits into from Jan 20, 2023
Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Jan 20, 2023

Summary

Only updateParticipationOverview if account index has been changed.

Changelog

- remove redundant resetDashboard()
- reset ParticipationOverview, when account index changes
- remove rerender when accountIndex changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi self-assigned this Jan 20, 2023
@Tuditi Tuditi linked an issue Jan 20, 2023 that may be closed by this pull request
3 tasks
@maxwellmattryan maxwellmattryan changed the title fix/state reset after logout fix: state reset after logout Jan 20, 2023
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MarkNerdi996 MarkNerdi996 merged commit 209e937 into develop Jan 20, 2023
@MarkNerdi996 MarkNerdi996 deleted the fix/state-reset-after-logout branch January 20, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Check if governance state is cleared after logging out.
3 participants