Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat-mobile: add feature to add nodes to settings #5625

Merged
merged 2 commits into from Jan 23, 2023
Merged

feat-mobile: add feature to add nodes to settings #5625

merged 2 commits into from Jan 23, 2023

Conversation

begonaalvarezd
Copy link
Member

Summary

Please summarize your changes, describing what they are and why they were made.

Close #5128

Changelog

- feat-mobile: add feature to add nodes to settings

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd self-assigned this Jan 20, 2023
@begonaalvarezd begonaalvarezd mentioned this pull request Jan 20, 2023
Merged
12 tasks
paul-boegelsack
paul-boegelsack approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@paul-boegelsack paul-boegelsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🔥

@paul-boegelsack paul-boegelsack merged commit 6a46d8b into develop Jan 23, 2023
@paul-boegelsack paul-boegelsack deleted the feat-mobile/add-node branch January 23, 2023 08:13
Tuditi pushed a commit that referenced this pull request Jan 23, 2023
@begonaalvarezd @paul-boegelsack @Tuditi
feat-mobile: add feature to add nodes to settings (#5625)
d94ebf8 
Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>
Tuditi added a commit that referenced this pull request Jan 23, 2023
@github-actions @crowdin-bot
@begonaalvarezd @paul-boegelsack @Tuditi @nicole-obrien @MarkNerdi996
New translations [ci skip] (#5554)
2b40ee7 
* feat: New Crowdin translations by Github Action

* feat-mobile: add feature to add nodes to settings (#5625)

Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>

* chore: update version (#5636)

Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>

* fix: open locahost in electron instead of external browser (#5635)

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

* chore: fix grammar

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio>
Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>
Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>
Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com>
Co-authored-by: Tuditi <daviddetroch@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-boegelsack paul-boegelsack paul-boegelsack approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@begonaalvarezd begonaalvarezd

Labels
context:settings stardust Related to the Stardust Protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Settings: Network configuration: Add node
2 participants
@begonaalvarezd @paul-boegelsack