Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat-mobile: add exclude/include & delete node to settings #5633

Merged
merged 10 commits into from Jan 26, 2023
Merged

feat-mobile: add exclude/include & delete node to settings #5633

merged 10 commits into from Jan 26, 2023

Conversation

begonaalvarezd
Copy link
Member

@begonaalvarezd begonaalvarezd commented Jan 21, 2023 •
edited

Summary

Please summarize your changes, describing what they are and why they were made.

Close #5132, close #5131

Changelog

feat-mobile: add exclude/include & delete node to settings

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd added type:feature Adding a new feature or functionality platform:mobile stardust Related to the Stardust Protocol labels Jan 21, 2023
@begonaalvarezd begonaalvarezd self-assigned this Jan 21, 2023
This was linked to issues Jan 21, 2023
[Task]: Settings: Network configuration: Remove node #5132
Closed
[Task]: Settings: Network configuration: Exclude node #5131
Closed
Base automatically changed from feat-mobile/primary-node to develop January 24, 2023 16:35
@begonaalvarezd begonaalvarezd marked this pull request as ready for review January 24, 2023 17:14
@begonaalvarezd begonaalvarezd linked an issue Jan 24, 2023 that may be closed by this pull request
[Task Tracker]: Settings: Network configuration #5119
Closed
7 tasks
paul-boegelsack
paul-boegelsack approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@paul-boegelsack paul-boegelsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🔥

@paul-boegelsack paul-boegelsack merged commit 1a96b87 into develop Jan 26, 2023
@paul-boegelsack paul-boegelsack deleted the feat-mobile/exclude-remove-node branch January 26, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-boegelsack paul-boegelsack paul-boegelsack approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

@amadeu2 amadeu2 Awaiting requested review from amadeu2

Assignees

@begonaalvarezd begonaalvarezd

Labels
stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Milestone
No milestone
2 participants
@begonaalvarezd @paul-boegelsack