Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: filter proposals #5664

Merged
merged 11 commits into from Jan 26, 2023
Merged

feat: filter proposals #5664

merged 11 commits into from Jan 26, 2023

Conversation

MarkNerdi996
Copy link
Contributor

Summary

This PR includes a filter popup to filter all proposals for various fields

Changelog

- add filter component to porposal list
- type fitler
- participated flag to proposal
- participated filter
- status filter

Relevant Issues

Clsoes #4870

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 self-assigned this Jan 24, 2023
Tuditi
Tuditi suggested changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some minor comments. Works well, good job!

packages/shared/locales/en.json Outdated
Comment on lines 1582 to 1585
"upcoming": "Announcement",
"commencing": "Voting open",
"holding": "Counting starts",
"ended": "Counting stops"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use the same locale's as we use for the labels?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrt translations for filters, the structure isnt that flexible...

packages/shared/components/filters/Filter.svelte Outdated Show resolved Hide resolved
packages/shared/lib/contexts/governance/utils/isVotingForProposal.ts Show resolved Hide resolved
@MarkNerdi996 MarkNerdi996 linked an issue Jan 25, 2023 that may be closed by this pull request
[Task]: Add filtering functionality for proposals #4870
Closed
3 tasks
Tuditi
Tuditi suggested changes Jan 25, 2023
View reviewed changes
packages/shared/lib/contexts/governance/stores/proposal-filter.store.ts Outdated
phase: {
active: false,
type: 'selection',
localeKey: 'filters.phase',
Copy link
Contributor

@Tuditi Tuditi Jan 25, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update this then to alleviate the burden on the translaters and to keep sure it's consistent across all languages? I guess the only thing that would need add is a label property to proposalStatus?

Suggested change
localeKey: 'filters.phase',
localeKey: 'proposalStatus',

Tuditi
Tuditi approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Tuditi Tuditi merged commit ae67555 into develop Jan 26, 2023
@Tuditi Tuditi deleted the feat/filter-proposals branch January 26, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

@jeeanribeiro jeeanribeiro Awaiting requested review from jeeanribeiro

@maxwellmattryan maxwellmattryan Awaiting requested review from maxwellmattryan

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@MarkNerdi996 MarkNerdi996

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add filtering functionality for proposals
2 participants
@MarkNerdi996 @Tuditi