Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci machines #5671

Merged
merged 6 commits into from Jan 26, 2023
Merged

fix: ci machines #5671

merged 6 commits into from Jan 26, 2023

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Jan 25, 2023

Summary

Update the outdated @types/node package and fix the electron-updater package version.

Aims to fix this issue: https://github.com/iotaledger/firefly/actions/runs/3997595702/jobs/6859134336#logs

Changelog

- @types/node -> 16.11.26
- electron-updater fixed package version

Relevant Issues

Please list any related issues (e.g. bug, task).

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi added scope:ci Affects CI actions type:fix Fix for bug labels Jan 25, 2023
@Tuditi Tuditi self-assigned this Jan 25, 2023
@Tuditi Tuditi marked this pull request as ready for review January 25, 2023 11:41
@maxwellmattryan maxwellmattryan merged commit 6bdaa0c into develop Jan 26, 2023
@maxwellmattryan maxwellmattryan deleted the fix/ci-machines branch January 26, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Affects CI actions type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants