Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify hint #5683

Merged
merged 10 commits into from Jan 31, 2023
Merged

feat: simplify hint #5683

merged 10 commits into from Jan 31, 2023

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Jan 27, 2023

Summary

Adds a voting power to zero popup to warn the user that setting their participation to zero will invalidate their votes. Additionally, this PR contains some improvements with regard to the revote popup

...

Changelog

- Add votingPowerToZero
- Force closing revote popup if clicked on submit
- Remove cancel flow from revote popup

Relevant Issues

closes: #5662
closes: #5619

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi self-assigned this Jan 27, 2023
@Tuditi Tuditi linked an issue Jan 27, 2023 that may be closed by this pull request
3 tasks
@Tuditi Tuditi marked this pull request as ready for review January 31, 2023 10:51
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice Job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants