Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: refactor calculate votes percentages and create tests #5691

Merged
merged 4 commits into from Jan 30, 2023
Merged

tests: refactor calculate votes percentages and create tests #5691

merged 4 commits into from Jan 30, 2023

Conversation

jeeanribeiro
Copy link
Contributor

Relevant Issues

closes #5588

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:refactor Refactor code type:tests Add or update tests context:governance stardust Related to the Stardust Protocol labels Jan 27, 2023
@jeeanribeiro jeeanribeiro self-assigned this Jan 27, 2023
@jeeanribeiro jeeanribeiro force-pushed the tests/calculate-votes-percentages branch from c4cc86d to fa97b3a Compare January 27, 2023 21:42
MarkNerdi996
MarkNerdi996 reviewed Jan 28, 2023
View reviewed changes
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
i would add 1 decimal place to the percentages, but thats just my preference, so if you (or design team) disagrees, feel free to ignore this

@jeeanribeiro jeeanribeiro merged commit 6300d85 into develop Jan 30, 2023
@jeeanribeiro jeeanribeiro deleted the tests/calculate-votes-percentages branch January 30, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkNerdi996 MarkNerdi996 MarkNerdi996 approved these changes

@maxwellmattryan maxwellmattryan Awaiting requested review from maxwellmattryan

@Tuditi Tuditi Awaiting requested review from Tuditi

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@jeeanribeiro jeeanribeiro

Labels
context:governance stardust Related to the Stardust Protocol type:refactor Refactor code type:tests Add or update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Write tests for calculateVotesPercentage
2 participants
@jeeanribeiro @MarkNerdi996