Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add voting power to balance summary #5696

Merged
merged 3 commits into from Jan 30, 2023

Conversation

MarkNerdi996
Copy link
Contributor

Summary

Adds voting power to the storage deposit breakdown

Changelog

- add voting power to the storage deposit breakdown

Relevant Issues

Close #5574

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:enhancement Enhancement to existing feature context:governance stardust Related to the Stardust Protocol labels Jan 30, 2023
@MarkNerdi996 MarkNerdi996 self-assigned this Jan 30, 2023
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunatly, this needs a broader redesign, since voting power is not part of the storage deposit breakdown. We need to rename the whole pop-up and have more information on it. I blocked the original task.

Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with Nicole, we agreed that we can include this. The wording needs a minor update and it's good to go!

packages/shared/locales/en.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM! 🔥

@Tuditi Tuditi merged commit 4044b0d into develop Jan 30, 2023
@Tuditi Tuditi deleted the enhancement/add-voting-power-to-balance-summary branch January 30, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:governance stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Update Balance breakdown to contain governance
2 participants