Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: percentages undefined #5703

Merged
merged 3 commits into from Jan 30, 2023
Merged

fix: percentages undefined #5703

merged 3 commits into from Jan 30, 2023

Conversation

jeeanribeiro
Copy link
Contributor

Summary

Percentages object should never be undefined otherwise it throws an error if the variable is undefined and the code is trying to access a property from it

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:fix Fix for bug context:governance stardust Related to the Stardust Protocol labels Jan 30, 2023
@jeeanribeiro jeeanribeiro self-assigned this Jan 30, 2023
maxwellmattryan
maxwellmattryan approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@maxwellmattryan maxwellmattryan merged commit e9f6d72 into develop Jan 30, 2023
@maxwellmattryan maxwellmattryan deleted the fix/percentages-undefined branch January 30, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwellmattryan maxwellmattryan maxwellmattryan approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@jeeanribeiro jeeanribeiro

Labels
context:governance stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeeanribeiro @maxwellmattryan