Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat-mobile: filter assets #5750

Merged
merged 7 commits into from Feb 10, 2023
Merged

feat-mobile: filter assets #5750

merged 7 commits into from Feb 10, 2023

Conversation

jeeanribeiro
Copy link
Contributor

@jeeanribeiro jeeanribeiro commented Feb 2, 2023 •
edited

Summary

Adds filter components, router, logic, and functional filtering of assets

Changelog

- Adds default value constant to each filter store
- Adds filter feature to mobile

Relevant Issues

closes #4954

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:feature Adding a new feature or functionality platform:mobile context:wallet labels Feb 2, 2023
@jeeanribeiro jeeanribeiro self-assigned this Feb 2, 2023
@jeeanribeiro jeeanribeiro force-pushed the feat/filter-assets branch 13 times, most recently from 4e5251c to 3e5f930 Compare February 7, 2023 16:57
@jeeanribeiro jeeanribeiro marked this pull request as ready for review February 7, 2023 17:07
begonaalvarezd
begonaalvarezd requested changes Feb 9, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks & works great 🔥, just added 2 comments.
Also, there are conflicts with base, we should fix the conflicts while combining search & filter 🙏🏼

packages/mobile/components/filters/FilterItem.svelte Outdated Show resolved Hide resolved
packages/mobile/components/filters/FilterItem.svelte Outdated Show resolved Hide resolved
@begonaalvarezd begonaalvarezd merged commit 77f9acf into develop Feb 10, 2023
@begonaalvarezd begonaalvarezd deleted the feat/filter-assets branch February 10, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

@paul-boegelsack paul-boegelsack Awaiting requested review from paul-boegelsack

@amadeu2 amadeu2 Awaiting requested review from amadeu2

Assignees

@jeeanribeiro jeeanribeiro

Labels
context:wallet type:feature Adding a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add filters to tokens/assets tab
2 participants
@jeeanribeiro @begonaalvarezd