Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: show correct unit on slider min max #5764

Merged
merged 2 commits into from Feb 6, 2023

Conversation

MarkNerdi996
Copy link
Contributor

Summary

The min and max under the slider input should be in the selected unit

Changelog

- update value and unit of min/max under slider input

Relevant Issues

Please list any related issues (e.g. bug, task).

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 self-assigned this Feb 3, 2023
@MarkNerdi996 MarkNerdi996 linked an issue Feb 3, 2023 that may be closed by this pull request
3 tasks
@MarkNerdi996 MarkNerdi996 marked this pull request as ready for review February 3, 2023 09:40
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Tuditi Tuditi merged commit 16c06e7 into develop Feb 6, 2023
@Tuditi Tuditi deleted the enhancement/show-correct-unit-on-slider-min-max branch February 6, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Slider max/min should also display glow if glow is selected
2 participants