New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: remove trailing spaces on url input #5773
enhancement: remove trailing spaces on url input #5773
Conversation
I would not strip all spaces in an url but only trailing and leading spaces. As a best practise (secutiry wise but also unwanted side effects) you should not change the url if that changes the location. |
it wouldnt really change the location, because a url with spaces is invalid and it would just correct it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should trim eventID as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🔥
Summary
...
Changelog
Relevant Issues
Testing
Platforms
Instructions
...
Checklist