Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: remove trailing spaces on url input #5773

Merged
merged 5 commits into from Feb 6, 2023

Conversation

MarkNerdi996
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 commented Feb 6, 2023

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Relevant Issues

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@JannemanDev
Copy link

I would not strip all spaces in an url but only trailing and leading spaces. As a best practise (secutiry wise but also unwanted side effects) you should not change the url if that changes the location.

@MarkNerdi996
Copy link
Contributor Author

I would not strip all spaces in an url but only trailing and leading spaces. As a best practise (secutiry wise but also unwanted side effects) you should not change the url if that changes the location.

it wouldnt really change the location, because a url with spaces is invalid and it would just correct it.
But i agree that i'm gonna remove this, because its a bit shady if we manipulate the user input, whereas they should check and change it themselves

Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should trim eventID as well?

Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Tuditi Tuditi merged commit 0d0ae6c into develop Feb 6, 2023
@Tuditi Tuditi deleted the enhancement/remove-trailing-spaces-on-urlinput branch February 6, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: An url with a prefixing space(s) and/or trailing space(s) it gives an error
3 participants