Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Button size changing suddenly after loading state #5814

Merged
merged 1 commit into from Feb 8, 2023

Conversation

jeeanribeiro
Copy link
Contributor

Summary

The Button component is changing its size suddenly after changing states, it is happening because of the CSS performance, to solve this, the dynamic values were replaced by static by avoiding calc() functions with CSS variables.

Changelog

- Simplify button sizing by replacing the dynamic calculations with variables for static values

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:fix Fix for bug package:shared stardust Related to the Stardust Protocol labels Feb 8, 2023
@jeeanribeiro jeeanribeiro self-assigned this Feb 8, 2023
@jeeanribeiro jeeanribeiro changed the title fix: Button sizing changing suddenly fix: Button size changing suddenly after loading state Feb 8, 2023
@jeeanribeiro jeeanribeiro linked an issue Feb 8, 2023 that may be closed by this pull request
3 tasks
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@maxwellmattryan maxwellmattryan merged commit a9e4fbb into develop Feb 8, 2023
@maxwellmattryan maxwellmattryan deleted the fix/button-busy-size branch February 8, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Polish UI: Fix button size issue while loading
2 participants