New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hackathon: replace ts-loader for esbuild-loader #5827
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeanribeiro
added
type:enhancement
Enhancement to existing feature
scope:dependencies
Affects dependencies
package:desktop
platform:desktop
Desktop application
labels
Feb 9, 2023
jeeanribeiro
requested review from
amadeu2,
maxwellmattryan,
Tuditi and
MarkNerdi996
February 9, 2023 19:31
jeeanribeiro
force-pushed
the
hackathon/esbuild-loader
branch
from
February 9, 2023 20:42
96ec6cf
to
4551e88
Compare
jeeanribeiro
force-pushed
the
hackathon/esbuild-loader
branch
from
February 9, 2023 20:44
027a655
to
e75dfa6
Compare
6 tasks
maxwellmattryan
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
platform:desktop
Desktop application
scope:ci
Affects CI actions
scope:dependencies
Affects dependencies
type:enhancement
Enhancement to existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Webpack build is slowing down our development time, to improve productivity would be better to implement optimizations to it. This PR changes the
ts-loader
foresbuild-loader
on the desktop package as it is a faster typescript code transpiler.Note: type checking is lost in the build process but in the development environment this side effect is not as costly as having super slow build times as we can always rely on the IDE and the CI.
Changelog
Testing
Platforms
Instructions
Checklist