Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hackathon: replace ts-loader for esbuild-loader #5827

Merged
merged 8 commits into from Feb 10, 2023

Conversation

jeeanribeiro
Copy link
Contributor

@jeeanribeiro jeeanribeiro commented Feb 9, 2023

Summary

Webpack build is slowing down our development time, to improve productivity would be better to implement optimizations to it. This PR changes the ts-loader for esbuild-loader on the desktop package as it is a faster typescript code transpiler.

Note: type checking is lost in the build process but in the development environment this side effect is not as costly as having super slow build times as we can always rely on the IDE and the CI.

Changelog

- Replace ts-loader for esbuild-loader in desktop webpack config
- Adds esbuild-loader dependency in desktop package.json
- Removes ts-loader dependency in desktop package.json
- Adds type-checking script in package.json
- Adds new CI for type-checking

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

  • Build it with and without the esbuild-loader to feel how less painful the building time can be

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added scope:ci Affects CI actions package:shared labels Feb 9, 2023
@maxwellmattryan maxwellmattryan linked an issue Feb 9, 2023 that may be closed by this pull request
6 tasks
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@maxwellmattryan maxwellmattryan merged commit 1ba0495 into develop Feb 10, 2023
@maxwellmattryan maxwellmattryan deleted the hackathon/esbuild-loader branch February 10, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:desktop Desktop application scope:ci Affects CI actions scope:dependencies Affects dependencies type:enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Optimize Webpack bundler
2 participants