Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: governance loading animations #5837

Merged
merged 8 commits into from Feb 13, 2023

Conversation

MarkNerdi996
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 self-assigned this Feb 10, 2023
@MarkNerdi996 MarkNerdi996 linked an issue Feb 10, 2023 that may be closed by this pull request
3 tasks
@nicole-obrien nicole-obrien added type:enhancement Enhancement to existing feature context:governance stardust Related to the Stardust Protocol labels Feb 10, 2023
@MarkNerdi996 MarkNerdi996 force-pushed the enhancement/governance-loading-animations branch from d2a69ac to 6fc6523 Compare February 13, 2023 08:27
@MarkNerdi996 MarkNerdi996 marked this pull request as ready for review February 13, 2023 08:28
@MarkNerdi996 MarkNerdi996 force-pushed the enhancement/governance-loading-animations branch from 6fc6523 to 2f13ceb Compare February 13, 2023 09:16
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We need to completly refactor the proposal details view at some point, lots of loading bugs etc and its hard to debug

@nicole-obrien nicole-obrien merged commit 85420c4 into develop Feb 13, 2023
@nicole-obrien nicole-obrien deleted the enhancement/governance-loading-animations branch February 13, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:governance stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Include governance loading state on the governance tab
2 participants