Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds search in activities #5838

Merged
merged 5 commits into from Feb 15, 2023
Merged

feat: adds search in activities #5838

merged 5 commits into from Feb 15, 2023

Conversation

jeeanribeiro
Copy link
Contributor

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:feature Adding a new feature or functionality platform:mobile stardust Related to the Stardust Protocol labels Feb 10, 2023
@jeeanribeiro jeeanribeiro self-assigned this Feb 10, 2023
@jeeanribeiro jeeanribeiro linked an issue Feb 10, 2023 that may be closed by this pull request
[Task]: Add searchbox to activity tab #5104
Closed
5 tasks
begonaalvarezd
begonaalvarezd requested changes Feb 13, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great! Just noticed some minor things, added comments 🙏🏼

packages/mobile/components/ActivityList.svelte Outdated Show resolved Hide resolved
packages/mobile/components/ActivityList.svelte Outdated Show resolved Hide resolved
begonaalvarezd
begonaalvarezd requested changes Feb 14, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep getting a crash 🙏🏼 added the error message

begonaalvarezd
begonaalvarezd approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@begonaalvarezd begonaalvarezd merged commit b4d472b into develop Feb 15, 2023
@begonaalvarezd begonaalvarezd deleted the feat-mobile/search-activity branch February 15, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

@paul-boegelsack paul-boegelsack Awaiting requested review from paul-boegelsack

@amadeu2 amadeu2 Awaiting requested review from amadeu2

Assignees

@jeeanribeiro jeeanribeiro

Labels
stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add searchbox to activity tab
2 participants
@jeeanribeiro @begonaalvarezd