New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix claiming for timelocked activity #5849
Conversation
559a502
to
f01efd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have sent you some comments privately about cases that are not working as expected
7f9cb21
to
4ec7850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still have some issues with the states of the activity tiles.
When I am sending with a SDRUC only, it is showing the timelock icon from both sender and receiver perspective.
When sending witha timelock to an external address, it is showing the timelock on the senders activity when it is not needed.
When a timelock or expiration unlock expires we no longer need to show the icon.
…claiming-on-timelocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
This PR fixes the calculation of the async status for activities. And with this fix, timelocked activities are again claimable
Changelog
Testing
Platforms
Instructions
...
Checklist