Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-mobile: polish filter styles #5869

Merged
merged 3 commits into from Feb 15, 2023
Merged

Conversation

begonaalvarezd
Copy link
Member

Summary

Please summarize your changes, describing what they are and why they were made.

This PR implements 2 changes:

  • Polish spacing in token & activity tabs for search & filter
  • Remove svelte transitions in filter drawer because there was something causing an odd jump in the activity amount filter

Close #5868

Changelog

- feat-mobile: polish filter styles

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

Copy link
Contributor

@paul-boegelsack paul-boegelsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@paul-boegelsack paul-boegelsack merged commit 089a3b1 into develop Feb 15, 2023
@paul-boegelsack paul-boegelsack deleted the feat-mobile/polish-filters branch February 15, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Polish UI: Improve token/activity search/filter spacing
2 participants