Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manage voting power when stronghold locked #5897

Merged
merged 2 commits into from Feb 16, 2023

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Feb 16, 2023

Summary

Enforce closing a popup before opening the unlockStrongholdPopup

...

Changelog

- Update yarn.lock
- Add closePopup(true)

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi self-assigned this Feb 16, 2023
@Tuditi Tuditi linked an issue Feb 16, 2023 that may be closed by this pull request
3 tasks
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicole-obrien nicole-obrien merged commit 86b6132 into develop Feb 16, 2023
@nicole-obrien nicole-obrien deleted the fix/manage-voting-power-when-stronghold-locked branch February 16, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix unlockStrongholdPassword popup doesn't overlay revote popup
2 participants