Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: improve apply filter button #5912

Merged
merged 1 commit into from Feb 20, 2023

Conversation

MarkNerdi996
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

This PR updates the Apply button on the filter modal, such that it doesnt get active when i change an inactive filter

Changelog

- update condition for activated apply button

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:enhancement Enhancement to existing feature context:wallet stardust Related to the Stardust Protocol labels Feb 17, 2023
@MarkNerdi996 MarkNerdi996 self-assigned this Feb 17, 2023
@MarkNerdi996 MarkNerdi996 linked an issue Feb 17, 2023 that may be closed by this pull request
3 tasks
@MarkNerdi996 MarkNerdi996 force-pushed the enhancement/imrpove-apply-filter-button branch from d5ae186 to 8710201 Compare February 20, 2023 14:44
@MarkNerdi996 MarkNerdi996 merged commit 99d378c into develop Feb 20, 2023
@MarkNerdi996 MarkNerdi996 deleted the enhancement/imrpove-apply-filter-button branch February 20, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Only highlight apply button if filter checkbox is ticked.
2 participants