Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: glitch when sending output #5916

Merged
merged 4 commits into from Feb 21, 2023
Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Feb 17, 2023

Summary

Fixed the glitch when the dashboard router was reset from within the send confirmation popup.

...

Changelog

- Removed dashboardRouter.reset()
- Added check if NFT was removed and go back if so

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi added the type:fix Fix for bug label Feb 17, 2023
@Tuditi Tuditi self-assigned this Feb 17, 2023
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkNerdi996 MarkNerdi996 merged commit 9341bcc into develop Feb 21, 2023
@MarkNerdi996 MarkNerdi996 deleted the fix/glitch-when-sending-output branch February 21, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix transaction inclusion of a regular transaction jumping to wallet dashboard
2 participants