Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-mobile: add legal drawer and view #5923

Merged
merged 6 commits into from Feb 23, 2023

Conversation

paul-boegelsack
Copy link
Contributor

Summary

Adds a drawer to view the terms of use and a view to accept the updated terms

Closes #5697

Changelog

- Adds legal drawer and legal updated view

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@paul-boegelsack paul-boegelsack added type:feature Adding a new feature or functionality platform:mobile stardust Related to the Stardust Protocol labels Feb 20, 2023
@paul-boegelsack paul-boegelsack self-assigned this Feb 20, 2023
Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is looking good!
I've found some room for improving readability and adhering to the code conventions 👀

@paul-boegelsack
Copy link
Contributor Author

The code is looking good! I've found some room for improving readability and adhering to the code conventions 👀

Great review! 👍 Let me know if there is something left 🙏

Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConditionOfUse.svelte mobile component is basically the same as ConditionsOfUse.svelte in desktop folder
I think it would be better for the codebase to have this component in shared folder and just reference it in the necessary places
Sorry for not checking it before, I think that after it the PR is good to be merged

Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looking good, congrats man! 🚀🔥

@jeeanribeiro jeeanribeiro merged commit 84e4677 into develop Feb 23, 2023
@jeeanribeiro jeeanribeiro deleted the feat-mobile/add-legal-drawer-and-view branch February 23, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add legal drawer and view
2 participants