New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat-mobile: add legal drawer and view #5923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is looking good!
I've found some room for improving readability and adhering to the code conventions 👀
packages/mobile/views/onboarding/views/app-setup/drawers/LegalDrawer.svelte
Outdated
Show resolved
Hide resolved
packages/mobile/views/onboarding/views/app-setup/views/WelcomeView.svelte
Outdated
Show resolved
Hide resolved
packages/mobile/views/onboarding/views/app-setup/views/WelcomeView.svelte
Outdated
Show resolved
Hide resolved
packages/mobile/views/onboarding/views/app-setup/views/WelcomeView.svelte
Outdated
Show resolved
Hide resolved
packages/mobile/views/onboarding/views/app-setup/drawers/LegalDrawer.svelte
Outdated
Show resolved
Hide resolved
packages/mobile/views/onboarding/views/app-setup/drawers/LegalDrawer.svelte
Outdated
Show resolved
Hide resolved
packages/mobile/views/onboarding/views/app-setup/drawers/LegalDrawer.svelte
Outdated
Show resolved
Hide resolved
packages/mobile/views/onboarding/views/app-setup/views/WelcomeView.svelte
Outdated
Show resolved
Hide resolved
Great review! 👍 Let me know if there is something left 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConditionOfUse.svelte mobile component is basically the same as ConditionsOfUse.svelte in desktop folder
I think it would be better for the codebase to have this component in shared folder and just reference it in the necessary places
Sorry for not checking it before, I think that after it the PR is good to be merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looking good, congrats man! 🚀🔥
Summary
Adds a drawer to view the terms of use and a view to accept the updated terms
Closes #5697
Changelog
Testing
Platforms
Instructions
...
Checklist