Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use popupid everywhere #5930

Merged
merged 2 commits into from Feb 21, 2023
Merged

chore: use popupid everywhere #5930

merged 2 commits into from Feb 21, 2023

Conversation

MarkNerdi996
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 self-assigned this Feb 20, 2023
@MarkNerdi996 MarkNerdi996 linked an issue Feb 20, 2023 that may be closed by this pull request
[Task]: Use PopupId everywhere to open popups #5931
Closed
5 tasks
@MarkNerdi996 MarkNerdi996 added type:chore House-keeping etc. stardust Related to the Stardust Protocol labels Feb 20, 2023
@MarkNerdi996 MarkNerdi996 marked this pull request as ready for review February 20, 2023 16:51
@MarkNerdi996 MarkNerdi996 requested review from Tuditi and maxwellmattryan and removed request for cvarley100 February 20, 2023 16:52
Tuditi
Tuditi suggested changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve the conflicts and then it's good to go! 🔥

Tuditi
Tuditi approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Tuditi Tuditi merged commit d0ea49d into develop Feb 21, 2023
@Tuditi Tuditi deleted the chore/use-popupid-everywhere branch February 21, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

@maxwellmattryan maxwellmattryan Awaiting requested review from maxwellmattryan

Assignees

@MarkNerdi996 MarkNerdi996

Labels
stardust Related to the Stardust Protocol type:chore House-keeping etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Use PopupId everywhere to open popups
2 participants
@MarkNerdi996 @Tuditi